Volodymyr Paprotski
Volodymyr Paprotski
@iwanowww Hope the extra tests passed? (Or do you have to re-run them on the latest patch again?)
@ascarpino Hi Tony, this is the ECC P256 PR we talked about last year, would appreciate your feedback.
> In `ECOperations.java`, if I understand this correctly, it is to replace the existing `PointMultiplier` with montgomery-based PointMuliplier. But when I look at the code, I see both are still...
> Few early comments. > > Please update the copyright year of all the modified files. > > You can even consider splitting this into two patches, Java side changes...
> Few early comments. > > Please update the copyright year of all the modified files. > > You can even consider splitting this into two patches, Java side changes...
@ascarpino Fixed as suggested... actually.. that was _waaay_ easier then I thought it would be (I saw singleton and assumed private constructor.. nope, ECOperations() is public, no reflection required!! Ended...
Thanks Sandhya! Now that I have @ascarpino approval as well, I plan to integrate next Tuesday.
Hi @TobiHartmann , merged with no issues for me. Could you please run the tests again? (I think Tony did run them, but can't hurt verifying again). Thanks!
Thanks Tobi! /integrate