Purging of Templates flag, IPMI Interface support, PSK Authentication

[cbergmann]

Pull Request (PR) description

This Pull request implements three Features:

1. It adds a new parameter purge_templates to zabbix_agent that controls if additional templates configured in the server for the zabbix_host resource should be deleted.
2. it implements psk authentication for zabbix_host resources
3. it fixes a problem with zabbix_host resources with only IPMI interfaces

I found no easy way to split these commits into three PRs. If you know how to do this I would highly appreciate this.

This Pull Request (PR) fixes the following issues

[bastelfreak]

thanks for the awesome PR! I left some inline comments. I'm afraid we need to get https://github.com/voxpupuli/puppet-zabbix/pull/699 green somehow first. That will fix most of your CI failures. I'm very familiar with Puppet, but not that much with Zabbix. If you've any clue with https://github.com/voxpupuli/puppet-zabbix/pull/699 fails please respond there. that would unblock many other PRs as well.

[aclarkee]

FYI @cbergmann as of zabbix 5.4 - PSK values are write only. Current logic on 5.4.x triggers a refresh of the PSK values on every run, since they can't be read back to verify.

Any chance you've fixed that in your environment?

[cbergmann]

FYI @cbergmann as of zabbix 5.4 - PSK values are write only. Current logic on 5.4.x triggers a refresh of the PSK values on every run, since they can't be read back to verify.

Any chance you've fixed that in your environment?

Unfortunately I am currently not using this Module. I forwarded this information to my former colleagues and will come back to you if they had found a workaround.

[aclarkee]

FYI @cbergmann as of zabbix 5.4 - PSK values are write only. Current logic on 5.4.x triggers a refresh of the PSK values on every run, since they can't be read back to verify. Any chance you've fixed that in your environment?

Unfortunately I am currently not using this Module. I forwarded this information to my former colleagues and will come back to you if they had found a workaround.

Thanks - I have made a workaround myself, but it's pretty much a bodge - and not really worthy of being merged in..

Would like to see a better fix from someone who better understands ruby/puppet exported resources :)

[vox-pupuli-tasks[bot]]

Dear @cbergmann, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks