zabbix::agent::userparameter not used userparameter and unsafeuserparameter

[TJM]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 6.0.5
• Ruby:(embedded) 2.4.4p296
• Distribution: CentOS 7.6
• Module version: 6.7 (master branch too)

How to reproduce (e.g Puppet code you use)

Set zabbix::agent::userparameter in hieradata...

What are you seeing

no effect on config

What behaviour did you expect instead

Maybe zabbix agent should call zabbix::userparameter with data set to its $userparameter? That might cause an issue if someone also sets zabbix::userparameter::data in hieradata, and expects that to work though. Probably should just remove these parameters so no one else finds them and tries to use them? (shrug)

Output log

N/A

Any additional information you'd like to impart

https://github.com/voxpupuli/puppet-zabbix/blob/master/manifests/agent.pp#L263-L264

These appear to be part of an old implementation, perhaps they should be deprecated/removed?

I have looked through the code and can't seem to find anywhere that uses these parameters, but I could be just missing something. :)

~tommy