puppet-windows_firewall icon indicating copy to clipboard operation
puppet-windows_firewall copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Removing rule with program set fails

Open ghost opened this issue 3 years ago • 0 comments

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.21.1
  • Ruby: 2.5.8p224
  • Distribution: Windows
  • Module version: 4.0.0

How to reproduce (e.g Puppet code you use)

Set windows exception for absent when a program is set (for a rule that was previously created with puppet)

What are you seeing

Windows complains about the command used to remove the FW rule stating that "action" is not valid for the command.

What behaviour did you expect instead

FW rule should be removed

Output log

Any additional information you'd like to impart

The issue seems to be here https://github.com/voxpupuli/puppet-windows_firewall/blob/master/manifests/exception.pp#L156 Removing the and $program == undef resolves the issue, but I'm not sure why that was added in the first place.

ghost avatar Jul 16 '21 21:07 ghost