puppet-wildfly icon indicating copy to clipboard operation
puppet-wildfly copied to clipboard

deploy_cache_dir defaults to /opt

Open nvergottini opened this issue 7 years ago • 5 comments

deploy_cache_dir defaults /opt, which does not seem like a good place for your jar files to land. Should this point to somewhere within the WildFly install home (/opt/wildfly/standalone/deployments?) or is this meant to be somewhere outside of the WildFly install home?

nvergottini avatar May 03 '17 14:05 nvergottini

This is meant to be somewhere. It's just a dir for downloads.

This module do not use deployment-scanner for deployments ($WILDFLY_HOME/standalone/deployments), it uses Management API instead, for two reasons:

  • It works the same way for both execution modes (domain and standalone)
  • It provides a synchronous feedback about a deployment. (i.e. you know when it fails)

jairojunior avatar May 03 '17 14:05 jairojunior

Thanks. That clears it up. Just seems that /opt is not a good default.

nvergottini avatar May 03 '17 15:05 nvergottini

It probably isn't, as /var/cache/wget

But it's been there since older releases and I couldn't find a better place. Do you have any suggestions? 😄

jairojunior avatar May 03 '17 15:05 jairojunior

Too bad Puppet doesn't provide a common place for file staging. How about /var/cache/biemond-wildfly?

nvergottini avatar May 03 '17 15:05 nvergottini

Puppet has a vardir (https://docs.puppet.com/puppet/4.10/dirs_vardir.html) which I thought about, but don't think it's a good idea.

Something in /var/cache/ would be more appropriate, never thought about biemond-wildfly, but might be a good idea. Although I would rather use something generic that already exist. 🤔

jairojunior avatar May 03 '17 16:05 jairojunior