minimize changes with default unattended-upgrades configuration

[anarcat]

I'd like us to consider the idea that this module should do a minimal diff with a default unattended-upgrades configuration.

There are two main ways of doing so:

1. do not touch the default config at all and instead configure in a separate file
2. do rewrite the configuration but keep the existing commented out lines

We could also mix and match, for example new features like #144 could be done in a separate file completely.

What do people think here?

[baldurmen]

@anarcat

I'm not entirely sure I understand why this is important. Could you please elaborate? It seems to me it doesn't really matter if you can reproduce the default configuration on your side with the module.

If this is implemented, I think I would prefer option 2, as option 1 means some configuration wouldn't be managed by the module (and that means inconsistency imo).

[anarcat]

I'm not entirely sure I understand why this is important. Could you please elaborate?

I think it's important that Puppet modules do not diverge needlessly from shipped configurations. For new users, it makes it hard to review if the package is doing what they expect, because there can be spurious diffs (e.g. on whitespace or comments) with the existing configuration files.

It seems to me it doesn't really matter if you can reproduce the default configuration on your side with the module.

Well that's part of the problem: it's hard for admins to actually tell if they are reproducing default config, because of the extra diff.

If this is implemented, I think I would prefer option 2, as option 1 means some configuration wouldn't be managed by the module (and that means inconsistency imo).

The problem with option 2 is that it is harder to keep in sync. But I agree consistency might be best.