puppet-telegraf icon indicating copy to clipboard operation
puppet-telegraf copied to clipboard

Add logfile rotation variables to the telegraf config file

Open jschoewe opened this issue 4 years ago • 7 comments

Pull Request (PR) description

This PR adds optional logfile rotation variables for the telegraf config file. Without these variables our log files are becoming too large and filling up the drive space on our backup servers

jschoewe avatar Aug 17 '20 20:08 jschoewe

I've never used this CI tool before but I'm kind of confused because it's giving me syntax errors in files that I didn't touch. Should I fix those as well?

jschoewe avatar Aug 18 '20 13:08 jschoewe

that's currently failing because of an updated dependency. I tried to fix that in https://travis-ci.org/github/voxpupuli/puppet-telegraf/builds/714241007 (https://github.com/voxpupuli/puppet-telegraf/pull/147) but I'm not yet sure why the tests fail :(

bastelfreak avatar Aug 18 '20 13:08 bastelfreak

Dear @jschoewe, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Aug 18 '20 15:08 vox-pupuli-tasks[bot]

Dear @jschoewe, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Sep 30 '20 23:09 vox-pupuli-tasks[bot]

BUMP

Any chance of getting this reviewed?

albatrossflavour avatar May 26 '23 01:05 albatrossflavour

@albatrossflavour thie PR needs to be rebased. If you like you can checkout the branch, rebase it and submit it as new PR

bastelfreak avatar May 26 '23 06:05 bastelfreak

Since #211 has been merged, this can likely be closed. @jschoewe any objections?

albatrossflavour avatar Jul 03 '23 02:07 albatrossflavour