puppet-systemd icon indicating copy to clipboard operation
puppet-systemd copied to clipboard

Add a socket_service definition

Open ekohl opened this issue 4 years ago • 4 comments

For systemd socket activated services it's needed to have both the .socket and .service unit defintions in place when starting the service. Prior to 97dd16fa32886b5b0f77a6f38a4953d4c1511c0e the systemctl daemon-reload took care of it, but now this must be done explicitly.

This new defined type makes it easy and reduces the burden on modules that define the unit/service pair.

I haven't tested this yet, but submitting it early so I can run CI on it and link it elsewhere.

ekohl avatar May 26 '21 12:05 ekohl

systemd::socket_service is a type

that may have no external impact to Forge modules.

This module is declared in 8 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

In https://github.com/theforeman/puppet-pulpcore/pull/199 I'm testing if the approach works. A draft until then.

ekohl avatar May 26 '21 12:05 ekohl

This now fails on https://tickets.puppetlabs.com/browse/MODULES-11018. I'll add a workaround.

ekohl avatar May 31 '21 15:05 ekohl

I've rebased this, but too tired to fix the dependency cycles now.

ekohl avatar Jan 26 '23 21:01 ekohl