puppet-splunk icon indicating copy to clipboard operation
puppet-splunk copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Add support for using a proxy to install Splunk

Open haught opened this issue 3 years ago • 3 comments

Pull Request (PR) description

This PR adds support to use a given proxy for install the forwarder and enterprise Splunk. It simply passes the options to puppet-archive.

This Pull Request (PR) fixes the following issues

haught avatar Apr 07 '22 19:04 haught

thanks for the PR! Can you add some tests for the changes?

bastelfreak avatar Apr 08 '22 07:04 bastelfreak

I looked through the tests before I PR'd and really didn't see anything like it that would test for this change. The change doesn't change a config file or anything, it just passes along two variables to puppet-archive. I am not even sure what I would be testing for.

haught avatar Apr 08 '22 17:04 haught

You could test the values of the archive resource attributes given various inputs.

kenyon avatar Apr 08 '22 20:04 kenyon