puppet-splunk WIP: Fix issues 230, 232, 235, and 249

Moved defaults to module data, and removed the params class
Privatized all splunk::enterprise:: and splunk::forwarder:: install, config, and service classes
Added a $release param, which replaces the $version param
- For ensurable package_providers, the release is used as the Splunk package ensure, if specified
- The release no longer defaults to a specific version and build, instead, the Splunk package resource defaults ensure to 'installed'
- Added a Splunk::Release type
Added a service_ensure param, per #249
Modified splunk*_version facts to be part of splunkforwarder and splunkenterprise fact hashes
Removed init.pp, which only served to confuse
$[enterprise,forwarder]_package_src and $package_source params renamed to $managed_package_source and $unmanaged_package_source, for clarity
Fixed: enterprise and forwarder password classes cross-referenced params

Fixed #230 Fixed #232 Fixed #235 Fixed #249

Jul 31 '19 20:07 nick-markowski

The bulk of the changes are done, but here are a few notes about the initial commit:

This commit finalizes what the original refactor should have been. The module much more closely follows the module best practices, and the refactor was necessary to fix a number of the issues reported by users.
Still need to expand upon the README and update REFERENCES.md.
I've been experiencing an issue with splunk_config redefining types and throwing errors during puppet-applys, for instance:

  Info: Redefining splunk_distsearch in Puppet::Type
  Error: Could not autoload puppet/type/splunk_config: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/splunk_distsearch'. Originally set at file:/etc/puppetlabs/code/modules/splunk/lib/puppet/type/splunk_distsearch.rb?line=3.
  Error: Evaluation Error: Error while evaluating a Resource Statement, Could not autoload puppet/type/splunk_config: Attempt to redefine entity 'http://puppet.com/2016.1/runtime/type/splunk_distsearch'. Originally set at file:/etc/puppetlabs/code/modules/splunk/lib/puppet/type/splunk_distsearch.rb?line=3. (file: /etc/puppetlabs/code/modules/splunk/manifests/enterprise.pp, line: 311, column: 3) on node centos7-64-1.home

Jul 31 '19 20:07 nick-markowski

@ody Thank you for the review! I've really dragged my feet digging into this PR after submitting. By now it'll probably need a nasty rebase, but I'll try to get the feedback addressed and get things rolling again.

Oct 08 '19 19:10 nick-markowski