Puppet did not detect changes in `/etc/redis.conf` neither reapplied the template

[alexfouche]

What are you seeing (the issue)

Someone modified /etc/redis.conf and put bogus values (either security issue or other guy mistake, or simply forgotten manual configuration change on machine), and future runs of Puppet never detected the change nor reapplied the correct configuration. I even myself spent a bit of time trying to figure out why Puppet runs did not recreated the file even when i deleted it from the machine

What behaviour did you expect instead

Puppet would

1. detect the /etc/redis.conf file has been modified
2. optionnally output the diff
3. reapply the template to recreate a correct file

Why

Because there: https://github.com/voxpupuli/puppet-redis/blob/d0ee587d0d0327ef85d5701fbd6c9d9f33569fbe/manifests/instance.pp#L312

This is not the real configuration file which is checked by Puppet, but rather a substitute file ! Since the real /etc/redis.conf file is not managed by a Puppet ressource, Puppet does not detect any changes, nor shows diff !