puppet-r10k icon indicating copy to clipboard operation
puppet-r10k copied to clipboard

Webhook in v11 non functional, v12 incompatible

Open linuxdaemon opened this issue 2 years ago • 0 comments

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.26.0
  • Ruby: 2.7.8p225 (puppet embedded)
  • Distribution: Ubuntu 20.04/22.04
  • Module version: v11.0.1

How to reproduce (e.g Puppet code you use)

  1. Define an environment with puppet-fail2ban 4.2.0 and puppet-r10k 11.0.1
  2. Try to deploy the webhook
  3. It fails because the service name is wrong, which was fixed in v12
  4. Can't upgrade to v12 as that requires stdlib >= 9.0 and puppet-fail2ban requires < 9.0.0

What behaviour did you expect instead

I would hope this sort of minor fix can be easily backported to 11.0.1, to allow those of us still stuck on stdlib 8.x to use the webhook.

Output log

Error: Systemd start for webhook failed!
journalctl log for webhook:
-- Logs begin at Wed 2023-02-22 02:31:51 UTC, end at Mon 2023-10-09 21:13:13 UTC. --
-- No entries --

Error: /Stage[main]/R10k::Webhook::Service/Service[webhook]/ensure: change from 'stopped' to 'running' failed: Systemd start for webhook failed!
journalctl log for webhook:
-- Logs begin at Wed 2023-02-22 02:31:51 UTC, end at Mon 2023-10-09 21:13:13 UTC. --
-- No entries --

Any additional information you'd like to impart

I suppose the other fix is to update puppet-fail2ban to support the new stdlib, but there are a slew of other modules in the same boat, so it would lead right back here with just a different second module.

linuxdaemon avatar Oct 09 '23 21:10 linuxdaemon