Remove dependency on abrader/gms or change the readme

[witchbutter]

trafficstars

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.8
• Module version: 6.7.0

How to reproduce (e.g Puppet code you use)

If you follow the explicit instructions on the forge to add a webhook:

# Resource git_webhook is provided by https://forge.puppet.com/abrader/gms
git_deploy_key { 'add_deploy_key_to_puppet_control':
  ensure       => present,
  name         => $::fqdn,
  path         => '/root/.ssh/id_dsa.pub',
  token        => hiera('gitlab_api_token'),
  project_name => 'puppet/control',
  server_url   => 'http://your.internal.gitlab.server.com',
  provider     => 'gitlab',
}

This causes failure if you are on a version of Puppet 5 because abrader/gms has not been updated in so long. Abrader/gms is not listed as a dependency and yet in order to complete the setup in the readme, it is required.

What are you seeing

Leads to errors like this:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Could not autoload puppet/type/git_deploy_key: no such file to load -- puppet_x/gms/type (file: /etc/puppetlabs/code/environments/development/site/profiles/manifests/puppet/webhook.pp, line: 29, column: 3) on node puppet.myexampledomain.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

What behaviour did you expect instead

If you are going to rely on a git_deploy_key and a git_webhook resource to correctly use the r10k module then that dependency needs to be called out or the code included in this module. Otherwise the readme should show how to set up the webhook manually.

[benh57]

There are some fixes in abrader/gms github which resolve this, but they haven't been integrated. Ideally it would move to voxpupuli.

[jacac]

Any updates on this?

[blargism]

I think it is safe to say the GMS project called out in the documentation is dead. No updates in years.

[bschonec]

I've been trying for more than a year to contact abrader, even to go as far as contacting Gary Larizza from Puppet to see if Gary could get ahold of Andrew. Unfortunately, Andrew has completely disappeared. It would be beneficial if voxpupuli could do a 'takeover' of abrader/gms.

[bschonec]

#591