puppet-python icon indicating copy to clipboard operation
puppet-python copied to clipboard

Ensure curl package

Open sp-ricard-valverde opened this issue 5 years ago • 0 comments
trafficstars

https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L36

This assumes curl is installed, but it should be added as a package requirement. Furthermore the command will return a 0 successful code if the python binary is present but curl is not, masking the failure and making puppet think the Exec resource applied successfully.

Same here: https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L52

sp-ricard-valverde avatar Feb 17 '20 11:02 sp-ricard-valverde