Wrong type for $python::dotfile::filename

[psychonaut]

https://github.com/voxpupuli/puppet-python/commit/a990c0b91343d9a706bd8aa4848ad49c4cf309a3 is wrong code, Stdlib::Filemode should be used as type for $mode variable, not for $filename. $filename is path, not permission.

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.3
• Ruby: ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-linux]
• Distribution: Centos7
• Module version: master branch

How to reproduce (e.g Puppet code you use)

Use python::dotfile { '/any/valid/path': }

What are you seeing

Parser error.

What behaviour did you expect instead

Proper dot file

Output log

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Python::Dotfile[/etc/pip.conf]: parameter 'filename' expects a match for Stdlib::Filemode = Pattern[/^[0124]{1}[0-7]{3}$/], got '/any/valid/path'

Any additional information you'd like to impart

[danquack]

#446 should resolve this.

[bastelfreak]

Hi @psychonaut, this should be fixed now. Please reopen if you still experience issues.