$targetfile in puppetserver::config::bootstrap doesn't respect puppetserver 5.1.x

[Phil-Friderici]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: puppet-agent-5.3.4-1.el7.x86_64 & puppetserver-5.1.5-1.el7.noarch
• Ruby: 2.0.0
• Distribution: CentOS Linux release 7.4.1708 (Core)
• Module version: 3.0.0

How to reproduce (e.g Puppet code you use)

use puppetserver 5.1.5

What are you seeing

$targetfile in puppetserver::config::bootstrap is set to '/etc/puppetlabs/puppetserver/bootstrap.cfg' in dependency of the puppet agent version.

What behaviour did you expect instead

puppetserver 5.1.5 is using '/etc/puppetlabs/puppetserver/services.d/ca.cfg' instead. $targetfile should be choosen by dependency of the installed puppetserver version not the agent version.

Output log

no output, functionality is silently ignored when the file isn't existing

Any additional information you'd like to impart

workaround: create a symlink pointing to the new location.

The puppet agent version number is not conclusive to set puppetserver details. If we don't have a fact for puppetserver version, $targetfile should become a parameter with the current default values. This way you could override the (now) outdated defaults.