puppet-puppetboard icon indicating copy to clipboard operation
puppet-puppetboard copied to clipboard

Add EL 9 support

Open kenyon opened this issue 1 year ago • 7 comments

  • delete Suse hiera data. Suse support was dropped from metadata.json in #292 commit 77ea67b22f2ef24920ec56f01e2658770a0a3b9d due to lack of working tests.
  • metadata.json: Add EL 9 support
  • Includes #388

kenyon avatar Dec 18 '23 20:12 kenyon

Would it make sense to change hiera to search the os.family instead of (or in addition to) os.name? centos 9, alma 9, rocky 9, rhel 9 all have the same python version (and likely always will in the same family).

h0tw1r3 avatar Dec 18 '23 23:12 h0tw1r3

Would it make sense to change hiera to search the os.family instead of (or in addition to) os.name? centos 9, alma 9, rocky 9, rhel 9 all have the same python version (and likely always will in the same family).

Like I mentioned in https://github.com/voxpupuli/puppet-puppetboard/pull/401#pullrequestreview-1787637278, I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

kenyon avatar Dec 19 '23 17:12 kenyon

Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

That's not possible as the python module specifies "3" as the default, el-8's all ship with python 3.6, but puppetboard required python 3.8 - 3.11.

h0tw1r3 avatar Dec 19 '23 22:12 h0tw1r3

Like I mentioned in #401 (review), I think it makes the most sense to eliminate the need to specify Python version in this module. But improving hiera.yaml is probably also a good idea.

That's not possible as the python module specifies "3" as the default, el-8's all ship with python 3.6, but puppetboard required python 3.8 - 3.11.

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

kenyon avatar Dec 19 '23 22:12 kenyon

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

Unfortunately, it does as python code/applications (virtualenv's) have different python interpreter requirements... which is definitely out of the sysadmins control.

The underlying problem, as I see it, is that the puppet python module only supports managing a single version of python. So if you must support different versions, you can't do it in a consistent way with puppet.

h0tw1r3 avatar Dec 19 '23 22:12 h0tw1r3

Yeah, I didn't look into the implementation details yet, but it doesn't make sense that every module using python should have to define the OS's default python version, right?

Unfortunately, it does as python code/applications (virtualenv's) have different python interpreter requirements... which is definitely out of the sysadmins control.

The underlying problem, as I see it, is that the puppet python module only supports managing a single version of python. So if you must support different versions, you can't do it in a consistent way with puppet.

I am just saying that the data about which version is the OS default should be centralized, so that other modules can look it up. That doesn't prevent overriding the default.

kenyon avatar Dec 19 '23 22:12 kenyon

Same comment as https://github.com/voxpupuli/puppet-puppetboard/pull/388#issuecomment-1880245313

kenyon avatar Jan 08 '24 00:01 kenyon

Acceptance tests are hanging trying to install puppetlabs/puppetdb because we don't have a Forge release that supports stdlib 9. https://github.com/puppetlabs/puppetlabs-puppetdb/issues/381 😡

kenyon avatar Apr 17 '24 00:04 kenyon