puppet-prometheus icon indicating copy to clipboard operation
puppet-prometheus copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Update default external_labels

Open wilfriedroset opened this issue 3 years ago • 2 comments
trafficstars

Pull Request (PR) description

The following commit sets external_labels to an empty hash by default. The previous value prevent the use of deep-merge strategy for the key prometheus::global_config when using hiera.

⚠️ This might be a breaking change for some users

This Pull Request (PR) fixes the following issues

None

wilfriedroset avatar Jun 16 '22 06:06 wilfriedroset

Thanks for the PR. I would like to keep this open until we've a few breaking changes and can relase all of them in a new major release.

bastelfreak avatar Jun 19 '22 13:06 bastelfreak

@bastelfreak any chance to get this merged and released?

wilfriedroset avatar Mar 05 '23 19:03 wilfriedroset

promethes::global_config is set as class parameter now. Thus this is not applicable anymore.

TheMeier avatar Dec 30 '24 12:12 TheMeier