puppet-prometheus icon indicating copy to clipboard operation
puppet-prometheus copied to clipboard

Move the URL releases to their own directory under /opt to create the…

Open SaschaDoering opened this issue 3 years ago • 1 comments
trafficstars

Move the URL releases to their own directory under /opt to create the possibility for Puppet to remove old releases that are no longer used.

Pull Request (PR) description

In order to achieve that Puppet can clean up the directory in which Prometheus and the exporters are located, I have created a subdirectory under /opt. This allows Puppet to purge the directory which would lead to unwanted behavior with /opt.

However, this would reinstall all exporters once, which would require one-time manual clean-up. Then you can have that automatically.

So that the change is minimally invasive, I have the whole thing activated via a variable that is deactivated by default.

Please let me know if anything is missing or if my approach does not fit.

This Pull Request (PR) fixes the following issues

Fixes #625

SaschaDoering avatar Jun 15 '22 15:06 SaschaDoering

Hi @SaschaDoering , thanks for the PR. Can you please add a unit test for this? Also an acceptance test would be helpful the verifies that the cleanup process is working.

bastelfreak avatar Jun 19 '22 13:06 bastelfreak