puppet-prometheus icon indicating copy to clipboard operation
puppet-prometheus copied to clipboard

Add parameter user / group for ressource archive

Open dhoppe opened this issue 5 years ago • 6 comments
trafficstars

Fixes #448

dhoppe avatar May 25 '20 08:05 dhoppe

rebased the commit

bastelfreak avatar Jun 11 '20 18:06 bastelfreak

rebased

bastelfreak avatar Jun 24 '20 09:06 bastelfreak

Is there any way to push for this PR?

ndelic0 avatar Aug 24 '20 16:08 ndelic0

@ndelic0 I rebased it again.In case the acceptance tests fail again it would be nice if someone could investigate why they fail.

bastelfreak avatar Aug 25 '20 21:08 bastelfreak

these checks appear to be passing the failing tests are initial connection tests failing on the host running the test ? or are there other tests failing that I can't see ?

I'm happy to work through the failures to get this merged and released as it's a good fix for a frustrating bug.

ikonia avatar Sep 16 '20 06:09 ikonia

Dear @dhoppe, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 21 '22 19:06 vox-pupuli-tasks[bot]

Closing due to inactivity. @dhoppe feel free to re-open

TheMeier avatar Dec 29 '24 20:12 TheMeier