postgres_exporter: extra_options vs options

[mika]

Inside postgres_exporter.pp we have:

#  [*extra_options*]
#  Extra options added to the startup command
#  For a full list of the exporter's supported extra options
#  please refer to https://github.com/wrouesnel/postgres_exporter

... while the option is actually called $options and only supported as such.

Either the docs should be adjusted or support for extra_options should be added (to keep the behavior with other exporters in sync?). (I'm not sure how to properly do the later one without breaking existing setups, that's why I don't provide a PR yet.)

[zeha]

I just ran into this as well. The other exporters seem to call it extra_options, so should this be renamed in postgres_exporter too?

[TheMeier]

The docs have been changed. Actually options is not documented now :( About changing it to extra_options, I am not sure if this inconsistency warrants a breaking change.