puppet-postfix icon indicating copy to clipboard operation
puppet-postfix copied to clipboard

EL7 postfix chroot

Open cdenneen opened this issue 7 years ago • 9 comments

Currently the following change applies:

Info: Applying configuration version '003e0658d144095db0dc546ed0e8c3a4aedb328c'
Notice: /Stage[main]/Postfix::Files/File[/etc/postfix/master.cf]/content:
--- /etc/postfix/master.cf	2018-05-22 14:48:32.461110827 -0400
+++ /tmp/puppet-file20180522-3533-1p8t2rt	2018-05-22 14:49:58.283204671 -0400
@@ -30,7 +30,7 @@
 verify    unix  -       -       -       -       1       verify
 flush     unix  n       -       -       1000?   0       flush
 proxymap  unix  -       -       n       -       -       proxymap
-smtp      unix  -       -       n       -       -       smtp
+smtp      unix  -       -       -       -       -       smtp
 # When relaying mail as backup MX, disable fallback_relay to avoid MX loops
 relay     unix  -       -       -       -       -       smtp
 	-o fallback_relay=

Info: Computing checksum on file /etc/postfix/master.cf

but causes issues:

May 22 14:50:05 ctcgit01 postfix/postfix-script[10757]: starting the Postfix mail system
May 22 14:50:05 ctcgit01 postfix/master[10759]: daemon started -- version 2.10.1, configuration /etc/postfix
May 22 14:50:05 ctcgit01 postfix/qmgr[10761]: AEE03C01E475: from=<[email protected]>, size=480, nrcpt=1 (queue active)
May 22 14:50:05 ctcgit01 postfix/smtp[10768]: fatal: unknown service: smtp/tcp
May 22 14:50:05 ctcgit01 postfix/postfix-script[10785]: refreshing the Postfix mail system
May 22 14:50:05 ctcgit01 postfix/master[10759]: reload -- version 2.10.1, configuration /etc/postfix
May 22 14:50:05 ctcgit01 postfix/qmgr[10797]: AEE03C01E475: skipped, still being delivered
May 22 14:50:06 ctcgit01 postfix/master[10759]: warning: process /usr/libexec/postfix/smtp pid 10768 exit status 1
May 22 14:50:06 ctcgit01 postfix/master[10759]: warning: /usr/libexec/postfix/smtp: bad command startup -- throttling

Guessing undef needs to be n rather than -?

cdenneen avatar May 22 '18 19:05 cdenneen

I'm not sure having to set postfix::chroot: false should be required here rather than fixing why it's breaking. Should there be /var/spool/postfix/etc structure created with necessary files? Is there anyone running this on RedHat/CentOS?

cdenneen avatar May 22 '18 20:05 cdenneen

tbh, the best option here would be to set up acceptance tests for such features.

raphink avatar Oct 18 '18 13:10 raphink

Without this it’s broken. I’m not near computer to write tests for this. But I consider this kind of a critical bug fix for EL7

cdenneen avatar Oct 18 '18 13:10 cdenneen

If we can at least get a release for 1.6.1 that has the chroot => false parameter then this issue can be fixed later but for now in order to disable chroot we need a new release since 1.6.0

cdenneen avatar Oct 18 '18 15:10 cdenneen

Ah right, the chroot feature is not released yet so we wouldn't be breaking any releases if we changed the default behavior. I'm guessing defaulting to n is fine, if that works with all OSes.

raphink avatar Oct 19 '18 07:10 raphink

https://github.com/camptocamp/puppet-postfix/pull/224

raphink avatar Oct 19 '18 07:10 raphink

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 19 '21 14:04 stale[bot]

I think this has been fixed by merging #224, no?

olifre avatar Apr 19 '21 15:04 olifre

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '21 16:06 stale[bot]

I'm going to assume the issue was fixed by #224.

ekohl avatar Nov 21 '23 11:11 ekohl