puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

Add Ubuntu 22.04 support

Open martialblog opened this issue 3 years ago • 2 comments

Pull Request (PR) description

Since the PR #658 to add support for Ubuntu 22.04 wasn't moving forward, I tried to get things moving.

This adds Ubuntu 22.04 support.

This Pull Request (PR) fixes the following issues

No open issue regarding this feature.

martialblog avatar Oct 26 '22 14:10 martialblog

There were some existing lint errors, I added a new commit to address them.

martialblog avatar Oct 26 '22 14:10 martialblog

There are currently no Ubuntu 22.04 Acceptance Tests in the CI.

Ran the beaker suite locally without any issues:

BEAKER_setfile=ubuntu2204-64 bundle exec rake beaker
...
Finished in 1 minute 31.16 seconds (files took 36.78 seconds to load)
8 examples, 0 failures

martialblog avatar Oct 26 '22 14:10 martialblog

Please update metadata.json to add Ubuntu 22.04. That way the CI will run on his OS too.

smortex avatar Nov 01 '22 04:11 smortex

@smortex Hi, thanks for the hint. I updated the metadata

martialblog avatar Nov 01 '22 08:11 martialblog

Anything I can help with to get this train in the station? I'd love to see this merged for a downstream project.

Cheers Markus

martialblog avatar Nov 16 '22 08:11 martialblog