puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Do not create rundir

Open tmanninger opened this issue 2 years ago • 2 comments

I am using php7.4 from sury on debian 10. After every server reboot, this module creates the /var/run/php-fpm directory (which is not used by php-fpm) and triggers a reload, which resets all open connections to the php-fpm daemon.

This PR added an option to disable the managing of the /var/run/php-fpm directory

tmanninger avatar Jun 07 '22 14:06 tmanninger

Any feedback?

tmanninger avatar Sep 26 '22 12:09 tmanninger

Closing and re-openning to trigger CI. The PR is old and failing CI results are not available anymore. @tmanninger can you check the reason for failure and fix your PR accordingly. If you need help feel free to ask for help in this PR.

smortex avatar Sep 29 '22 06:09 smortex

Can you merge die MR?

tmanninger avatar Nov 28 '22 13:11 tmanninger

@tmanninger Please rebase with our master branch since there have been 2 releases since then 😄

root-expert avatar Dec 12 '22 12:12 root-expert

@root-expert my branch ist up2date now.

tmanninger avatar Dec 12 '22 12:12 tmanninger

Please do a rebase instead of a merge commit and squash your commits into one 😄

root-expert avatar Dec 12 '22 12:12 root-expert

I created a new MR: https://github.com/voxpupuli/puppet-php/pull/674 @root-expert You can close this MR.

tmanninger avatar Dec 13 '22 06:12 tmanninger