puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

Add support for Ubuntu 22.04

Open grant-veepshosting opened this issue 2 years ago • 5 comments

Pull Request (PR) description

Add support for Ubuntu 22.04

This Pull Request (PR) fixes the following issues

Add support for Ubuntu 22.04

grant-veepshosting avatar Mar 27 '22 22:03 grant-veepshosting

This is likely not working: https://github.com/voxpupuli/puppet-php/blob/c62cbb4303de656dfac375543c226ba3d5da9017/spec/classes/php_spec.rb#L23-L30

I suggest:

  • [x] wait for the 22.04 version to become available;
  • [x] https://github.com/voxpupuli/puppet_metadata/pull/39
  • [x] release a new version of puppet_metadata;
  • [x] have AIO Puppet packages available for Ubuntu 22.04;
  • [ ] Update metadata.json to test these changes.
  • [ ] have CI working.

smortex avatar Mar 28 '22 01:03 smortex

Ubuntu 22.04 is now a thing.

mpdude avatar Apr 25 '22 08:04 mpdude

Hello, as mentioned above, Ubuntu 22.04 is now available. Is there an update here?

That helps temporarily:

--- manifests/globals_old.pp    2022-06-24 14:03:42.558691014 +0200
+++ manifests/globals.pp        2022-06-24 13:56:42.580355330 +0200
@@ -32,6 +32,7 @@
     'Ubuntu' => $facts['os']['release']['major'] ? {
       '18.04' => '7.2',
       '20.04' => '7.4',
+      '22.04' => '8.1',
       default => fail("Unsupported Ubuntu release: ${fact('os.release.major')}"),
     },
     default => '5.x',

Thanks in advance.

msu-ts avatar Jun 24 '22 12:06 msu-ts

Let's retry the CI.

kenyon avatar Jun 24 '22 23:06 kenyon

@grant-veepshosting can you please rebase your changes to fix conflicts (and the CI failure should vanish at the same time) and add this release to metadata.json so that we can see which tests need work (I updated my first message above now that Puppet packages are available for 22.04)?

smortex avatar Sep 19 '22 17:09 smortex

Ubuntu 22.04 support done in #672.

kenyon avatar Dec 11 '22 22:12 kenyon