puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

Download stable version of composer as opposed to snapshot

Open plexium opened this issue 4 years ago • 3 comments

Pull Request (PR) description

Download stable version of composer as opposed to snapshot

This Pull Request (PR) fixes the following issues

Fixes #575

plexium avatar May 12 '20 13:05 plexium

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

bastelfreak avatar May 18 '20 10:05 bastelfreak

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

In my opinion this looks more like a bug fix:

By default the installer and composer self-update will download stable versions only. If you would like to help test pre-release versions you can use the --preview flag on either installer or self-update. For snapshot builds which are done from the latest Composer commit, you can use the --snapshot flag.

dhoppe avatar May 18 '20 10:05 dhoppe

Is this a backwards incompatible change? The fold url is still valid, just a different composer version?

Correct, it's still a valid url. I noticed this being a problem when provisioning a new node, the composer version that would install was a dev version, and caused a bunch of composer installs downstream in my manifests to fail. I would have to manually do a composer selfupdate after provisioning to get the stable version.

Since is saw the update branch defaults to the 'stable', so should the initial install.

I don't think it's a backwards incompatible change.

plexium avatar May 22 '20 01:05 plexium