puppet-php
puppet-php copied to clipboard
voxpupuli
Prevent creation of pid file directory
Pull Request (PR) description
This PR prevents the creation of the hardcoded pid file directory if it is not used.
This Pull Request (PR) fixes the following issues
Fixes #501
@bastelfreak any feedback on this PR or should we just close and leave the code as it is?
Dear @TuningYourCode, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @bastelfreak & @ghoneycutt,
how should we proceed with this PR? If there are any todos please tell me :) Feel free to close this PR if you do not like to merge it.
Please change to only remove the pid file directory and I'm +1 for merging.
@TuningYourCode there are merge conflicts and they must be resolved before we can review and merge this.
Dear @TuningYourCode, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Not sure why these tests fail, they do not check for presents of the removed definition.
Dear @TuningYourCode, thanks for the PR!
This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks