puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Adding the option to set process.dumpable

Open mhagstrand opened this issue 6 years ago • 6 comments

Pull Request (PR) description

Adding the option to set process.dumpable

This Pull Request (PR) fixes the following issues

If process.dumpable is disabled core dumps cannot be captured on segfaults even if rlimit_core is set because of the following change to PHP:

https://github.com/php/php-src/commit/276d19feaa43e6f77eeac59fc9e2639bee4d116b#diff-10cc4db817271640849c40a7fc1f0569

mhagstrand avatar Mar 19 '19 17:03 mhagstrand

process.dumpable isn't added until php-7.0.29. Need to add a version check.

mhagstrand avatar Mar 19 '19 18:03 mhagstrand

@bastelfreak any chance of a review on this one?

rayward avatar Oct 12 '20 01:10 rayward

hey @rayward. We're currently doing a rewrite of the module (check https://github.com/voxpupuli/puppet-php/projects/1 and https://github.com/voxpupuli/puppet-php/issues/604 and https://github.com/voxpupuli/puppet-php/issues/603). @SimonHoenscheid what's your opinion on this PR?

bastelfreak avatar Oct 17 '20 15:10 bastelfreak

@bastelfreak @rayward makes sense to me, please add option to manage rlimit_core set automatically if core dumps are set.

SimonHoenscheid avatar Oct 18 '20 20:10 SimonHoenscheid

@SimonHoenscheid Sounds good, I will take care of that and update the PR.

mhagstrand avatar Oct 18 '20 22:10 mhagstrand

Dear @mhagstrand, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jun 21 '22 19:06 vox-pupuli-tasks[bot]