puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard
verified publisher icon voxpupuli

Rhel repo update

Open mgrune9978 opened this issue 6 years ago • 5 comments

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

mgrune9978 avatar Feb 21 '19 12:02 mgrune9978

Hi @mgrune9978, thanks for the PR. Are you able to add some rspec/acceptance tests to it?

bastelfreak avatar Feb 21 '19 22:02 bastelfreak

Fixes https://github.com/voxpupuli/puppet-php/issues/480

bastelfreak avatar Feb 21 '19 22:02 bastelfreak

@mgrune9978 can you please take a look at the inline comments I made?

bastelfreak avatar Jul 28 '19 09:07 bastelfreak

Sorry @bastelfreak, I have little to no experience writing tests in puppet, although I should spend some time to learn it. I just can't find any good resources to give me a beginner starting point, which could be the problem with much of puppet to be honest. I was actually only updating my fork because that's what I'm using at the moment and I wanted php 7.3 support.

Anyway, I had assumed that Rathios was taking this over but I guess I misunderstood?

mgrune9978 avatar Jul 28 '19 15:07 mgrune9978

Dear @mgrune9978, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Aug 01 '20 11:08 vox-pupuli-tasks[bot]