puppet-openldap icon indicating copy to clipboard operation
puppet-openldap copied to clipboard

Published 20 hours ago • verified publisher icon voxpupuli

Fix unsafe interpolations

Open smortex opened this issue 2 years ago • 2 comments

We now have puppet-lint-check_unsafe_interpolations and it detect some issues. Fix them.

smortex avatar Aug 28 '23 21:08 smortex

Unfortunately due to https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations/issues/39 we are still required to disable the check.

smortex avatar Aug 28 '23 21:08 smortex

I updated the PR to use stdlib::shell_escape() in favor of shell_escape() (deprecated).

I also removed the comments to disable the check to avoid the false positives because:

  1. This check is not enabled by default;
  2. I opened https://github.com/puppetlabs/puppet-lint-check_unsafe_interpolations/pull/48 to fix the bug.

When a version of puppet-lint-check_unsafe_interpolations that can spot shell_escaped interpolations is released, we will be able to consider its inclusion at the voxpupuli level and this module should not raise any warning when this happen.

smortex avatar Apr 08 '24 23:04 smortex