installing from git

[onzyone]

when installing a module from git

  nodejs::npm { 'node-wimoto':
    ensure  => 'present',
    package => 'node-wimoto',
    source  => 'onzyone/node-wimoto',
    target  => '/opt/packages',
  }

source ends up in the grep as source is no longer registry

  if $source != 'registry' {
    $install_check_package_string = $source
    $package_string = $source

this fails and re installs the module over and over again as it is looking for

Debug: Exec[npm_install_node-wimoto](provider=posix): Executing check '/usr/bin/npm ls --long --parseable | grep "/opt/packages/node_modules/onzyone/node-wimoto"'
Debug: Executing: '/usr/bin/npm ls --long --parseable | grep "/opt/packages/node_modules/onzyone/node-wimoto"'

and not

grep "/opt/packages/node_modules/node-wimoto"'

[igalic]

@onzyone do you think you can provide a patch for this?

[onzyone]

Yup I am looking into it and will give one in the next few days.

On Mon, Sep 21, 2015 at 12:12 PM, Igor Galić [email protected] wrote:

@onzyone https://github.com/onzyone do you think you can provide a patch for this?

— Reply to this email directly or view it on GitHub https://github.com/puppet-community/puppet-nodejs/issues/166#issuecomment-142030701 .

[onzyone]

have a look at this and run a few tests: https://github.com/onzyone/puppet-nodejs/tree/onzyone-patch-1 and I will do merge

[igalic]

uhm… @onzyone if you create the pull request against this repo, then travis can take care of running tests for you :)

[jyaworski]

What's the status of this?

[igalic]

¯\(o_°)/¯

[juniorsysadmin]

If I recall correctly I think the bug is that the module assumes package rather than namespace/package for source