puppet-nodejs icon indicating copy to clipboard operation
puppet-nodejs copied to clipboard

Use a custom type within the nodejs::npm defined type

Open juniorsysadmin opened this issue 10 years ago • 3 comments

Currently the npm defined type uses some quite ugly blocks of code. Quite apart from the fact that this could put people off eating their dinner (which is probably quite delicious), things could be a simpler and more robust if a Custom Type was used instead, with nodejs::npm simply making calls to this custom type. Ideally most of code that invokes npm should be same in both the provider and in the defined type with the exception of one or two attributes.

juniorsysadmin avatar May 20 '15 12:05 juniorsysadmin

:+1: i think i remember saying something along those lines in my innitial review of your refactor pr ;)

igalic avatar May 26 '15 15:05 igalic

What's the status of this?

jyaworski avatar Feb 29 '16 00:02 jyaworski

What's the status of this?

Still wanted

juniorsysadmin avatar Feb 29 '16 03:02 juniorsysadmin