puppet-nginx icon indicating copy to clipboard operation
puppet-nginx copied to clipboard

Fix `apt-key` deprecated message

Open milad-zanganeh opened this issue 1 year ago • 2 comments

Pull Request (PR) description

In the current implementation, apt::source stores GPG keys in the trusted.gpg file, which is no longer recommended. Additionally, with the deprecation of apt-key, running the apt update command triggers warnings on Debian-based distributions. This PR modifies the handling of GPG keys so that they are stored in the keyrings directory, aligning with best practices and avoiding the deprecation warnings associated with apt-key

milad-zanganeh avatar Aug 23 '24 11:08 milad-zanganeh

given the "new" version for the dependency, should this be marked backward-incompatible?

TheMeier avatar Aug 26 '24 13:08 TheMeier

given the "new" version for the dependency, should this be marked backward-incompatible?

I think yes, because users of this module who use it with puppetlabs-apt would need to update their puppetlabs-apt module. Same as how we've done for this kind of change in other modules.

kenyon avatar Aug 26 '24 21:08 kenyon