Fix streamhost default logging

[jaketus]

Pull Request (PR) description

Current default value for stream_access_log will cause Nginx to fail to start if nginx::stream is true.

http://nginx.org/en/docs/stream/ngx_stream_log_module.html#access_log Format must be defined, which current default configuration doesn't do (since stream_custom_format_log is undef as well).

Nginx default is "off", and therefore the Puppet-module default should be "off" as well.

This Pull Request (PR) fixes the following issues

• #1530

[puppet-community-rangefinder[bot]]

nginx is a class

Breaking changes to this file WILL impact these 16 modules (exact match):

• dhollinger-devopsdays
• eelcomaljaars-friendica
• kalfa-sites
• samuelson-custom_webapp
• akisakye-matomo
• othalla-nextcloud
• jonhallettuob-existdb
• puppet-hyperglass
• pgassmann-letsencrypt_nginx
• stackstorm-st2
• ploperations-webhook_proxy
• cristifalcas-kibana
• landcareresearch-ckan
• aursu-lsys
• geoffwilliams-r_profile
• covata-safeshare

Breaking changes to this file MAY impact these 33 modules (near match):

• jmkeyes-netbox
• klynton-testing
• lboynton-gitlab
• nicopaez-dockerserver
• pltraining-selfpaced
• jbussdieker-graphite_web
• firm1-zds
• dmexe-deploy
• ramiel-owncloud
• braiins-wordpressnginx
• 4n0m4l0u5-configure_nginx
• aursu-grayloginstall
• danieldreier-puppet_installer
• qroac-isp3node
• compass-learninglocker
• adcade-statsd
• compass-examdb
• vormetriclabs-meteor
• chedi-django
• nicopaez-alfred
• nicopaez-triage
• tracywebtech-appdeploy
• ploperations-puppet
• mightp-librenms
• vshn-uhosting
• mtulio-profiles
• qtechnologies-psgi
• maestrodev-maestro_nodes
• puppetfinland-patchwork
• oris-appserver
• SchnWalter-happydev
• groupbuddies-gb
• halyard-boxen

This module is declared in 9 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[bastelfreak]

@jaketus can you please rebase against our latest master?