puppet-nginx icon indicating copy to clipboard operation
puppet-nginx copied to clipboard

Feature request: Make service notify configurable

Open khaefeli opened this issue 7 years ago • 0 comments

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.3.3-1
  • Ruby: -
  • Distribution: Debian Jessie
  • Module version: 0.9.0

How to reproduce (e.g Puppet code you use)

change a config (e.g. an upstream member) and see the puppet run log.

What are you seeing

Nginx service is reloading after config changes

What behavior did you expect instead

The service notify parameter should be configurable. (enable / disable) sometimes you don't want to auto refresh the prod config of the Nginx service. e.g. we're auto-adding upstream members to our main proxy's (over puppet export / puppetdb). but we don't want that the member change to be active / deployed, without any manual check, during the next puppet run.

Output log

Notice: /Stage[main]/Nginx::Service/Service[nginx]: Would have triggered 'refresh' from 1 event

Any additional information you'd like to impart

the puppetlabs/mysql module is doing that pretty well with the "restart" parameter

khaefeli avatar Dec 27 '17 11:12 khaefeli