puppet-mongodb icon indicating copy to clipboard operation
puppet-mongodb copied to clipboard

Add default localhost real_ip

Open justintime4tea opened this issue 4 years ago • 2 comments

Pull Request (PR) description

Sometimes you just want to add a user or two to Mongo and not manage it with this module (because you're using managing it through Foreman/Katello as an example). In this case maybe all you want to do is:

  class {'mongodb::globals':
    manage_package_repo => false,
    manage_package      => false
  }

  mongodb_user { 'SOME_USER':
    ensure        => present,
    name          => 'SOME_USER',
    password_hash => mongodb_password('SOME_USER', 'SOME_USER'),
    database      => 'admin',
    roles         => ['root', 'admin'],
    tries         => 10
  }

Well and then you get Empty host component parsing HostAndPort from ":27017" and realize that all that's missing is just the bind_ip and that you don't want to do anything else with this module but add users... that's where this PR comes in!

This PR will add a default bind_ip of 127.0.0.1. This may be a poor hack because I don't know ruby from an implicit returning hole in the ground :) Either way, lets talk about it? maybe I'm doing something wrong? This PR seems reasonable however.

justintime4tea avatar Dec 01 '19 06:12 justintime4tea

Apparently this doesn't even work regardless of the PR... it doesn't add the user :( I also realized moments after this hurdle that there is no custom role support (as far as I can tell) :( :( double frowny. If I had more time I'd try to contribute and add custom role support.

You can probably just close this as it's probably a worthless PR technically speaking.

justintime4tea avatar Dec 01 '19 06:12 justintime4tea

Dear @justintime4tea, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar May 01 '20 11:05 vox-pupuli-tasks[bot]

as noted by owner, this PR doesn't work. So closing it.

witjoh avatar Mar 28 '24 09:03 witjoh