puppet-mcollective icon indicating copy to clipboard operation
puppet-mcollective copied to clipboard

Deprecate this module in favour of https://github.com/choria-io/puppet-mcollective?

Open bastelfreak opened this issue 6 years ago • 10 comments

Hi everybody,

I would like to deprecate this module. Volcane put a lot of effort into the choria modules. The specific module is located at: https://forge.puppet.com/choria/mcollective_choria and the whole choria suite is documented at: https://choria.io/docs/deployment/mcollective/

I do not see why we should maintain an additional module next to the choria ones. @voxpupuli/collaborators please provide feedback.

bastelfreak avatar Aug 18 '18 18:08 bastelfreak

Since @ripienaar has taken over much of the MCO maintenance, I think it would be best to point users to the choria implementation instead of ours. I believe the official Puppet MCollective docs even point to Choria now.

https://puppet.com/docs/mcollective/current/deploy/plugins.html - they do for plugins

dhollinger avatar Aug 18 '18 18:08 dhollinger

I was going to ask the same question myself-- do we want to continue this as an alternative, or deprecate it?

I agree that the choria modules seem well designed, and I have no customers who wouldn't be best served by using those.

jorhett avatar Aug 18 '18 19:08 jorhett

Soonish all the old mco code and modules and everything related will move to the choria-legacy GitHub org (that’s the current plan anyway) and mco will leave puppet-agent rpm. At which point choria will be the only option and it will provide a comparability layer for old mco agents.

Much going on now but it seems to me worth consolidating around 1 project given the long abandonment phase etc we should focus around one activity for remaining users and future ones.

ripienaar avatar Aug 18 '18 20:08 ripienaar

Hmmm, that means those of us who use MCollective in a not very conventional way will need to migrate to Choria…

raphink avatar Aug 19 '18 18:08 raphink

Afraid so. No plans currently to do any further mco releases. What will be released will be a stripped down gem that provides RPC compat and ruby clients.

Be interested to hear your non conventional use cases. If you looked at choria you will see we are doing a ton of new interesting stuff that I doubt was ever done by any mco people. So I am keen to explore new areas.

ripienaar avatar Aug 19 '18 18:08 ripienaar

I have looked at choria, and implemented it (happily) at a customer. My problem is our old internal implementation, which uses e.g. SSH keys for authentication. It's actually the only PR left open on MCollective I see: https://github.com/puppetlabs/marionette-collective/pull/372

I'm guessing we'll have to let go of this and switch to Puppet certificates instead, right?

raphink avatar Aug 20 '18 06:08 raphink

Yeah I don’t intend to support SSH keys unfortunately.

I am doing a bunch of work on the security system though - support other CAs etc - though as I don’t want to be tied to PupprtCA

The turnkey choria suite is all puppet but the new choria daemon is for all sorts of places - IoT etc - so it’s a lot more flexible about things.

ripienaar avatar Aug 20 '18 06:08 ripienaar

I'll have to find time to test all this. Our server side is deployed with Docker, as part of our Dockerized Puppet stack, so this shouldn't be too hard to adapt I hope.

raphink avatar Aug 20 '18 06:08 raphink

@ripienaar The thing I'm missing in choria (or I missed it) is windows support. Are you planning to add that?

netdata-be avatar Aug 31 '18 12:08 netdata-be

@netdata as it stands today with the mcollectived it is supported. So right now on puppet < 6 you can run it on windows.

The future replacement daemon not yet, its on the list but time is tight, will be some time after 6 is released I suspect.

Already tests pass on windows etc, but I dont have a package (and dont know how to make one lol) so it'll be a bit.

ripienaar avatar Aug 31 '18 13:08 ripienaar