Use of $facts in mcollective::actionpolicy::rule conflicts with puppet's Trusted Facts feature

[mcallaway]

See http://docs.puppetlabs.com/puppet/3.6/reference/lang_facts_and_builtin_vars.html#trusted-facts

When one sets trusted_node_data = true in puppet.conf, you also enable the "facts" hash: http://docs.puppetlabs.com/puppet/3.6/reference/lang_facts_and_builtin_vars.html#the-facts-hash

This results in an error:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Attempt to assign to a reserved variable name: 'facts' at /etc/puppet/environments/production/modules/mcollective/manifests/actionpolicy/rule.pp:2 on node puppetmaster

[igalic]

i'm intruiged as to how it does this… is that just a random name-clash? /cc @richardc.

[richardc]

I have nothing to say on this.

[jyaworski]

Hello:

Is this still needed?