puppet-letsencrypt icon indicating copy to clipboard operation
puppet-letsencrypt copied to clipboard
verified publisher icon voxpupuli

rename environment parameter to unbreak hiera

Open igalic opened this issue 9 years ago • 12 comments

Fixes #63. We rename the environment to venv_vars in order to ensure that hiera calls do not break, as soon as a puppet execution flow enters our module. For consistency's sake, we change environment not only in the main class (where it's definitely needed: rodjek/puppet-lint#574), but also in the certonly define.

igalic avatar Dec 05 '16 17:12 igalic

@igalic Please resolve the merge conflicts.

dhoppe avatar Dec 29 '16 19:12 dhoppe

done

igalic avatar Jan 02 '17 14:01 igalic

This is a backwards incompatible change? Is it worth bumping the version number in metadata.json now? (so as not to forget later)

alexjfisher avatar Jan 02 '17 14:01 alexjfisher

Label is the right thing

juniorsysadmin avatar Jan 03 '17 02:01 juniorsysadmin

the basic question is: do we need a release before we merging this, yes/no?

igalic avatar Feb 09 '17 16:02 igalic

According to SemVer, we should publish a new release, right?

dhoppe avatar Feb 09 '17 17:02 dhoppe

This needs a rebase now due to conflicts.

ekohl avatar Dec 04 '18 16:12 ekohl

This needs a rebase now due to conflicts.

gosh it's bee a while

but it's done

igalic avatar Dec 05 '18 14:12 igalic

Dear @igalic, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Nov 21 '19 09:11 vox-pupuli-tasks[bot]

dear @pccibot,

as mentioned in my previous communique, this pull request is either obsolete, or it needs to be rethought.

Best regards,

i

igalic avatar Nov 21 '19 10:11 igalic

Dear @igalic, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 13:01 vox-pupuli-tasks[bot]

Dear @igalic, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] avatar Jan 05 '20 13:01 vox-pupuli-tasks[bot]