puppet-letsencrypt icon indicating copy to clipboard operation
puppet-letsencrypt copied to clipboard

Add environment parameter to renew cron

Open gmenuel opened this issue 2 years ago • 1 comments

Pull Request (PR) description

This PR add an option for adding environment to the global renew cron, this is useful for example with the nginx certbot plugin which somehow can't find nginx if the PATH in the cron doesn't include /usr/sbin.

This PR is similar to #189 which doesn't seem really active.

This Pull Request (PR) fixes the following issues

Fixes: #250 (well kind of, it doesn't directly fix this, but it allows to add the PATH in the cron which will fix the problem).

gmenuel avatar May 11 '22 07:05 gmenuel

Thanks!

hboetes avatar May 23 '22 23:05 hboetes

Just a quick question, is there anything holding this PR back? Running into issues where I need to set the PATH for this cron to add some dirs. Which this PR would solve If there are issues I don't mind taking a look and trying to fix it.

DJClean avatar Jul 18 '23 13:07 DJClean

Merge conflicts resolved.

gmenuel avatar Feb 06 '24 07:02 gmenuel