puppet-letsencrypt
puppet-letsencrypt copied to clipboard
voxpupuli
Add certbot-dns-ovh plugin support
Pull Request (PR) description
Add dns-ovh support based on dns_rfc2136 implementation
It looks correct. Could you have a look at adding tests to this as well? Other than that 👍 to merging.
I never write tests before but I'm gonna try.
Hi Ewoud, I was busy last days.. But I managed to add tests (largely inspired by rfc2136 plugin) and update README. Note that travis failed because package python3-certbot-dns-ovh is only available from Debian 10. How can we handle this ?
Dear @aellert, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
![vox-pupuli-tasks[bot] avatar](https://avatars.githubusercontent.com/in/37588?v=4 "Published by a pub.dev verified publisher"){kind=small}
Dear @aellert, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @aellert, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks
Dear @aellert, thanks for the PR!
This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?
You can find my sourcecode at voxpupuli/vox-pupuli-tasks