puppet-gluster
puppet-gluster copied to clipboard
If the peer name in the facts is not the same as in the configuration
Pull Request (PR) description
If the peer name in the facts is not the same as in the configuration: #gluster peer status --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> <cliOutput>
.........
<peerStatus>
<peer>
.........
<hostname>192.168.0.10</hostname>
<hostnames>
<hostname>192.68.0.10</hostname>
<hostname>gst03</hostname>
</hostnames>
..........
</peer>
<peer>
.........
<hostname>gst02</hostname>
<hostnames>
<hostname>gst02</hostname>
</hostnames>
.........
</peer>
</peerStatus>
</cliOutput>
Then the gluster_peer_list
fact will contain the following line: 192.168.0.10,gst02
and due to the fact that the configuration says gst03 and not IP, the following will always be executed: Notice: /Stage[main]/myclass /Gluster::Peer[gst03]/Exec[gluster peer probe gst03]/returns: executed successfully (corrective)
My edit takes all names from peers /cliOutput/peerStatus/peer/hostnames/hostname the fact string will be:
192.168.0.10,gst03,gst02
and then in line 52 of the manifests/peer.pp file it will find the value. After this, the command gluster peer probe gst03
will not be executed every time