puppet-gitlab icon indicating copy to clipboard operation
puppet-gitlab copied to clipboard

feature/package_hold

Open NeatNerdPrime opened this issue 1 year ago • 3 comments
trafficstars

Pull Request (PR) description

Introducing the package_holdparameter

The package_hold parameter allows you to hold the package version in the APT package manager. This is useful when you intend to update the host with 'apt upgrade' (or the bolt task apt action=upgrade from puppetlabs-apt) and keep your gitlab instance at the intended version. This prevents unintended upgrading gitlab and perhaps skipping important upgrade path steps.

NeatNerdPrime avatar Aug 23 '24 17:08 NeatNerdPrime

@bastelfreak Thanks for considering my PR.

NeatNerdPrime avatar Sep 10 '24 05:09 NeatNerdPrime

Thanks for the PR! Can you please add a unit test for the change?

bastelfreak avatar Sep 10 '24 06:09 bastelfreak

And Voila! Got done in a bit by the style, but it includes the test describes it quite nicely.

Thanks again for considering my PR :-)

NeatNerdPrime avatar Sep 10 '24 17:09 NeatNerdPrime

thanks for the work!

bastelfreak avatar Nov 04 '24 10:11 bastelfreak