puppet-gitlab icon indicating copy to clipboard operation
puppet-gitlab copied to clipboard

Inconsistencies comparing with my local installation

Open famfop opened this issue 5 years ago • 0 comments

I was going through my version's default gitlab.rb.template and comparing with this repo's template + init.pp. I found the following inconsistencies:

  • gitlab_shell is defined in the template and in the init.pp in the comments-section (@ param ...) but it is not defined in the gitlab-class definition.
  • omnibus_gitconfig defined in template and @ param section of init.pp but not in class definition

furthermore my installation gives the following options not defined in init.pp or the template:

  • Runtime directory (Docs: https://docs.gitlab.com//omnibus/settings/configuration.html#configuring-runtime-directory) with the config-line # runtime_dir '/run'
  • Gitlab Kubernetes Agent Server (Docs: https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/blob/master/README.md) with multiple config lines
  • Praefect (Docs: https://gitlab.com/gitlab-org/gitaly/blob/master/doc/design_ha.md) with multiple config lines
  • storage_check (has no "Docs" link given). Has 3 keys: 'enable', 'target', 'log_directory' (at least in my version...)
  • 'package'-hash. has the keys 'detect_init', 'systemd_tasks_max', 'systemd_after', 'systemd_wanted_by'. Again, no docs-link
  • Patroni (EE only) with notice that it "is an experimental feature and subject to change.". has multiple keys.

I was not really sure if the "gitlab-omnibus version" mentioned in the README is actually the gitlab version (?) but dpkg -l gitlab* tells me I am running gitlab-ce v13.5.4-ce.0.

famfop avatar Nov 19 '20 17:11 famfop