puppet-gitlab icon indicating copy to clipboard operation
puppet-gitlab copied to clipboard

Correct config for prometheus_monitoring

Open LongLiveCHIEF opened this issue 7 years ago • 0 comments

The parameter for prometheus_monitoring_enable should be just prometheus_monitoring. Reasons include:

  • consistency in usage and admin expectations
  • it's not just a simple true/false scenario, due to implicit defaults for both single-server and ha role handling scenarios
  • inflexibility if gitlab adds more supported attributes for this config

LongLiveCHIEF avatar Apr 09 '18 23:04 LongLiveCHIEF