puppet-fail2ban icon indicating copy to clipboard operation
puppet-fail2ban copied to clipboard

ok to consolidate classes?

Open ghoneycutt opened this issue 8 years ago • 9 comments

Hi @dhoppe

The module currently separates out functionality that should be in one class (fail2ban) into many subclasses (install, config, service). Each class should provide functionality on its own without having to chain them together with the anchor pattern, which has come to be an anti-pattern in puppet coding. I'm looking at adding support for EL6 and ensuring there is full spec coverage and wondering if it would be OK to refactor the module to get rid of the anchor pattern and subclasses.

Best regards, -g

ghoneycutt avatar Nov 01 '16 15:11 ghoneycutt