Accept Puppet-Datatype Sensitive

[cocker-cc]

• let the Hash containing the Secrets for the Keystore accept Secrets of Datatype Sensitive
• fix a 15-Months-old Typo-Bug

Pull request acceptance prerequisites:

• [x] Signed the CLA (if not already signed)
• [x] Rebased/up-to-date with base branch
• [ ] Tests pass
• [ ] Updated CHANGELOG.md with patch notes (if necessary)
• [ ] Updated CONTRIBUTORS (if attribution is requested)

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service[bot]]

💚 CLA has been signed

[bastelfreak]

thanks for the PR! can you add some tests with sensitive data?

[cocker-cc]

thanks for the PR! can you add some tests with sensitive data?

I would like to. But with this outdated Hiera 3 in use, I won't.
With Hiera 5 one could do something like…

---
lookup_options:
  elasticsearch::api_basic_auth_password:
    convert_to: Sensitive

elasticsearch::api_basic_auth_password: MY_API_BASIC_AUTH_PASSWORD

… to retrieve sensitive Strings from Hiera.

~So, if you mind to migrate to Hiera 5? I could do the Migration, but currently I am quite busy.~
I migrated the Fixtures-Hiera to Hiera 5 in this PR.