To allow upgrades user setup should use es version to set xpack/oss_xpack/shield

[choffee]

• Module version: 6.3.4
• Puppet version: 5.6
• OS and version: Ubuntu 18.04

Bug description

We have upgraded from ES 2.x and so have bits of sheild and x-pack hanging around on our servers still.

I had to remove the following directories for the module to stop guessing I was using shield with Elasticsearch 6.8.0

/usr/share/elasticsearch/bin/sheild /etc/elasticsearch/x-pack /etc/elasticsearch/instance/x-pack /etc/elasticsearch/instance/shield

Feature Description

I would be good if the module could work out from the ES version which plugin to use rather then just what old config dirs are left behind.