onceover icon indicating copy to clipboard operation
onceover copied to clipboard

modules installed by r10k are not removed when removed from Puppetfile if Puppetfile contains no other modules

Open jessereynolds opened this issue 6 years ago • 1 comments

Steps to reproduce:

  • have stdlib as the only module in your Puppetfile and use one of its functions eg fact()
  • do a run spec and witness tests passing
  • remove stdlib from your Puppetfile, so there's no modules listed at all
  • do a run spec

Expected result:

  • test failure due to stdlib being missing

Actual result:

  • tests keep passing because stdlib module still resides at: .onceover/etc/puppetlabs/code/environments/production/modules/stdlib with a symlink to that dir at: .onceover/spec/fixtures/modules/stdlib

In fact, the debug run still shows it is faithfully maintaining that symlink too:

DEBUG -> Symlinking /Users/jesse/src/puppet/gems/onceover/tmp/control-repos/simple/.onceover/etc/puppetlabs/code/environments/production/modules/stdlib to /Users/jesse/src/puppet/gems/onceover/tmp/control-repos/simple/.onceover/spec/fixtures/modules/stdlib

jessereynolds avatar Aug 29 '17 07:08 jessereynolds

This is caused by https://github.com/puppetlabs/r10k/issues/762

jessereynolds avatar Aug 29 '17 08:08 jessereynolds