json-schema icon indicating copy to clipboard operation
json-schema copied to clipboard

[472] - Fix for Accept nullable parameter

Open jahir-husain opened this issue 1 year ago • 8 comments

Fix for issue #472

jahir-husain avatar Jul 24 '23 07:07 jahir-husain

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (76ea712) 90.08% compared to head (f0051ff) 90.11%.

:exclamation: Current head f0051ff differs from pull request most recent head 3c7f264. Consider uploading reports for the commit 3c7f264 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   90.08%   90.11%   +0.03%     
==========================================
  Files          76       76              
  Lines        1584     1589       +5     
==========================================
+ Hits         1427     1432       +5     
  Misses        157      157              
Files Changed Coverage Δ
lib/json-schema/attribute.rb 100.00% <100.00%> (ø)
lib/json-schema/attributes/type.rb 100.00% <100.00%> (ø)
lib/json-schema/attributes/type_v4.rb 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 24 '23 08:07 codecov[bot]

@bastelfreak - Can you review this, Please.

jahir-husain avatar Aug 01 '23 07:08 jahir-husain

@jahir-husain can you please rebase against our latest master branch and squash the commits down?

bastelfreak avatar Aug 01 '23 09:08 bastelfreak

@jahir-husain can you please take a look at the comment and rebase against our latest master (so we get rid of the merge commits).

bastelfreak avatar Sep 15 '23 09:09 bastelfreak

@jahir-husain please rebase instead of doing a merge.

bastelfreak avatar Sep 20 '23 09:09 bastelfreak

any update?

kntmrkm avatar Apr 17 '24 00:04 kntmrkm

@kntmrkm this PR needs a rebase. If you want you can checkout the code locally, rebase it against our Head and then submit a new PR.

bastelfreak avatar Apr 17 '24 07:04 bastelfreak

nullable has never been a JSON Schema keyword. It used to be a keyword of OpenAPI's schema, though isn't anymore. I don't know that a JSON Schema validator should be validating keywords that aren't part of JSON Schema.

notEthan avatar Apr 17 '24 08:04 notEthan